Skip to content

refactor: Make token holder objects type-safe#6622

Draft
mvadari wants to merge 7 commits intomvadari/rearch/tokenfrom
mvadari/rearch/token-holder
Draft

refactor: Make token holder objects type-safe#6622
mvadari wants to merge 7 commits intomvadari/rearch/tokenfrom
mvadari/rearch/token-holder

Conversation

@mvadari
Copy link
Copy Markdown
Collaborator

@mvadari mvadari commented Mar 23, 2026

High Level Overview of Change

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mvadari mvadari changed the base branch from develop to mvadari/rearch/token March 23, 2026 16:53
@mvadari mvadari added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Mar 23, 2026
@mvadari mvadari force-pushed the mvadari/rearch/token branch from 18401a3 to b1537e9 Compare March 23, 2026 17:00
@mvadari mvadari force-pushed the mvadari/rearch/token-holder branch 2 times, most recently from e80902e to 7b94aff Compare March 23, 2026 17:21
@mvadari mvadari force-pushed the mvadari/rearch/token branch from bacd9a6 to 3bc4609 Compare March 23, 2026 18:10
@mvadari mvadari force-pushed the mvadari/rearch/token-holder branch from 7b94aff to 4a5ad89 Compare March 23, 2026 19:48
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 98.07692% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.5%. Comparing base (3bc4609) to head (cb0e839).

Files with missing lines Patch % Lines
src/libxrpl/ledger/helpers/MPTokenHelpers.cpp 91.7% 2 Missing ⚠️
src/libxrpl/ledger/helpers/RippleStateHelpers.cpp 77.8% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           mvadari/rearch/token   #6622   +/-   ##
====================================================
  Coverage                  81.4%   81.5%           
====================================================
  Files                      1000    1003    +3     
  Lines                     74625   74684   +59     
  Branches                   7589    7572   -17     
====================================================
+ Hits                      60768   60841   +73     
+ Misses                    13857   13843   -14     
Files with missing lines Coverage Δ
include/xrpl/ledger/helpers/MPToken.h 100.0% <100.0%> (ø)
include/xrpl/ledger/helpers/MPTokenHelpers.h 100.0% <100.0%> (ø)
include/xrpl/ledger/helpers/RippleState.h 100.0% <100.0%> (ø)
include/xrpl/ledger/helpers/RippleStateHelpers.h 100.0% <100.0%> (ø)
include/xrpl/ledger/helpers/TokenHelpers.h 100.0% <ø> (ø)
include/xrpl/ledger/helpers/TokenHolderBase.h 100.0% <100.0%> (ø)
src/libxrpl/ledger/helpers/TokenHelpers.cpp 91.5% <100.0%> (ø)
src/libxrpl/tx/transactors/check/CheckCash.cpp 92.4% <100.0%> (-<0.1%) ⬇️
src/libxrpl/tx/transactors/escrow/EscrowCreate.cpp 100.0% <100.0%> (ø)
src/libxrpl/tx/transactors/escrow/EscrowHelpers.h 96.2% <100.0%> (-<0.1%) ⬇️
... and 10 more

... and 10 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DraftRunCI Normally CI does not run on draft PRs. This opts in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant